Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for merging the PR about CSV encoding. I found a bug in an edge case after it was merged.
If a model has columns with serialized object, they don't respond to "encode!" but can include strings to encode.
e.g.
{a: "a", b: "あいうえお"}
["a", "あいうえお"]
So my solution here is encode any values after convert it to string since the values are converted sooner or later in CSV lib.
Could you consider to merge this fix?