-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSX SyntaxError breaks this plugin #28
Comments
Hello I am sorry I don't have time to investigate the bug. I added the badge, if someone have time to investigate it, it is welcome! |
Are you sure you have added the missing p tag. Just asking? |
@chrispcode this is not about my code, it's about error showing properly in overlay. Missing p tag was a simulated syntax error, if such error happens in create-react-app, it shows it in the error overlay just fine, if it happens using this plugin, it breaks because react-error-overlay dependency loads wrong babel js and the visual output is stuck on the ansi coded garbage error. |
Thanks for the update @Tungpin, feel free to submit a PR to fix this problem. |
Looks like it is fixed, feel free to reopen. |
I've set it up in my test project according to the Usage section and when I try a reference error as in the example, it works correctly. However, if I for example remove random closing tag in JSX, things break:
If you look at the second image, the weird part is
GET https://localhost:3000/babel/parser/lib/index.js 404 (Not Found)
which is requested from "node_modules/react-error-overlay". this breaks things. If I create similar SyntaxError in a create-react-app test app, this doesn't happen and a proper Failed to compile error appears in the overlay. Any ideas?The text was updated successfully, but these errors were encountered: