Options has an unknown property 'before'

[gorkunov]

Seems overlay doesn't work with latest webpack-dev-server v4.1.0.

Error:

 - options has an unknown property 'before'. These properties are valid:
   object { allowedHosts?, bonjour?, client?, compress?, devMiddleware?, headers?, historyApiFallback?, host?, hot?, http2?, https?, ipc?, liveReload?, magicHtml?, onAfterSetupMiddleware?, onBeforeSetupMiddleware?, onListening?, open?, port?, proxy?, setupExitSignals?, static?, watchFiles?, webSocketServer? }

this line is broken:

error-overlay-webpack-plugin/src/index.js

Line 27 in 6e62765

options.devServer.before = (app, server) => {

[WizardCM]

I can confirm I ran into the same issue today. Reproducible if the Webpack config has a simple

devServer: {}

And goes away if that option is not specified.

[thedavidprice]

Confirming this bug as well when trying to upgrade on RedwoodJS, which is using Webpack v5 and Webpack-dev-server v4 (compatible with v5).

There were many breaking changes in devServer v4:

• https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md

Looks like this change here:

The before option was renamed to onBeforeSetupMiddleware and changed arguments.

...is potentially causing an issue here:

error-overlay-webpack-plugin/src/index.js

Line 27 in fe2cd08

options.devServer.before = (app, server) => {

Additionally, it seems the following "sock*" changes will also cause problems:

public, sockHost, sockPath, and sockPort options were removed in favor client.webSocketURL option:

...over here:

error-overlay-webpack-plugin/src/index.js

Lines 15 to 17 in fe2cd08

	sockOptions.sockHost = compiler.options.devServer.sockHost
	sockOptions.sockPath = compiler.options.devServer.sockPath
	sockOptions.sockPort = compiler.options.devServer.sockPort

[gregberge]

Hi, could someone work on a PR to fix it?

[thedavidprice]

If someone can lead on the PR, I am available to help with questions and diagnosing issues. Just loop me in if/as needed.

[milosivanovic]

Hello! I posted a fix (#88) for this issue a week ago. @gregberge and @thedavidprice are you able to take a look?

[MichaelKheel]

Guys, please make a merge.