Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript support #79

Closed
gregberge opened this issue May 12, 2018 · 6 comments
Closed

TypeScript support #79

gregberge opened this issue May 12, 2018 · 6 comments

Comments

@gregberge
Copy link
Owner

As suggested in #14 it would be awesome to have a TypeScript support for Loadable Components.

This issue consist by adding Loadable Components types on DefinitelyTyped.

You can inspire by react-loadable types.
@gregberge gregberge mentioned this issue May 12, 2018
Closed
@theKashey
Copy link
Collaborator

I am 100% sure that home repo is the best place for types.

@gregberge
Copy link
Owner Author

Yeah it is a good option.

@theKashey
Copy link
Collaborator

Then assign it to me

@gregberge
Copy link
Owner Author

I can't but if you want to contribute you are welcome!

@theKashey theKashey mentioned this issue May 13, 2018
Merged
@gregberge
Copy link
Owner Author

Done in #80

@theKashey
Copy link
Collaborator

🤘🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregberge @theKashey