This repository has been archived by the owner on Nov 26, 2018. It is now read-only.
refactor(callOrUse): spare a function creation #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For our purpose, it's useless to return a function from `callOrUse`. Additionally, with the current implementation, the "callOrUse" name is a bit confusing because `callOrUse` doesn't call nor use the provided function or object. It just wraps it in a function. I was initially thinking of renaming this helper to something like `wrap` but I figured we do not actually need to "wrap" anything. So, let's stick with the "callOrUse" name and indeed call or use the provided function or object.
matthieuprat
force-pushed
the
improve-callOrUse
branch
from
b1edd46
to
6bd7596
Compare
|
Also, with this implementation, I guess |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our purpose, it's useless to return a function from
callOrUse.Additionally, with the current implementation, the "callOrUse" name is a
bit confusing because
callOrUsedoesn't call nor use the providedfunction or object. It just wraps it in a function.
I was initially thinking of renaming this helper to something like
wrapbut I figured we do not actually need to "wrap" anything.So, let's stick with the "callOrUse" name and indeed call or use
the provided function or object.