Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashify doesn't convert underscores in dash (lodash was doing it) #280

Closed
damien916 opened this issue Feb 20, 2019 · 1 comment
Closed

dashify doesn't convert underscores in dash (lodash was doing it) #280

damien916 opened this issue Feb 20, 2019 · 1 comment
Labels
bug 🐛 good first issue 🤙 help wanted 🆘 needs more info 🖐

Comments

@damien916
Copy link

Hello,

I use SVGR to convert icons with CLI, with --filename-case kebab option.
After upgrade SVGR from 2.1 to 4.1, icons aren't renamed in kebab case:

Before: next_circle.svg -> next-cirlce.svg
Now: next_circle.svg -> next_cirlce.svg

Is it intentional from your side ?
Thanks
@gregberge
Copy link
Owner

Hello @damien916, thanks for the report. We have to investigate it, is it a bug or just something expected, I don't really know.

gregberge added a commit that referenced this issue Apr 11, 2019
@gregberge
fix(cli): fix kebab case transformation with "_"
6366e73 
Closes #280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 good first issue 🤙 help wanted 🆘 needs more info 🖐
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregberge @damien916