Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@svgr/webpack: Add React Runtime Option #748

Closed
wants to merge 1 commit into from

Conversation

beeequeue
Copy link

@beeequeue beeequeue commented Jul 19, 2022

Simplifies the fix for #653, and should hopefully smooth things over for people not using babel in their projects

@vercel
Copy link

vercel bot commented Jul 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svgr ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 1:21PM (UTC)

@beeequeue beeequeue changed the title Add React Runtime Option @svgr/webpack: Add React Runtime Option Jul 19, 2022
@beeequeue
Copy link
Author

Might not be needed...

@beeequeue beeequeue closed this Jul 19, 2022
@kapiljaveri
Copy link

Hi @beeequeue, what was the reason for closing it and it not being needed? Is there some other approach to solving the issue?

@beeequeue
Copy link
Author

I figured i could use output options for svgr instead, but iirc neither that or this fixed the issue i was having

@kapiljaveri
Copy link

I'm not familiar with the output options much, but, what was the issue you were running into? I was actually looking for the very fix you had to pass in the runtime option.

@kapiljaveri
Copy link

Any way you could still get this merged in? :)

@beeequeue
Copy link
Author

The options I'm referring to is jsx-runtime, if @gregberge wants to merge this they can open it again (I think)

@kapiljaveri
Copy link

Ah ok yeah, that makes sense. For me jsx-runtime solved part of the issue as it still was required to be passed into babel.

Any possibility of geteting this merged in @gregberge? Or do you recommend an alternative route? My comments were in #653

@kapiljaveri
Copy link

Hi @gregberge, just checking-in again to see if this is something you'd possibly consider to merge in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants