-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@svgr/webpack
: Add React Runtime Option
#748
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@svgr/webpack
: Add React Runtime Option
Might not be needed... |
Hi @beeequeue, what was the reason for closing it and it not being needed? Is there some other approach to solving the issue? |
I figured i could use output options for svgr instead, but iirc neither that or this fixed the issue i was having |
I'm not familiar with the output options much, but, what was the issue you were running into? I was actually looking for the very fix you had to pass in the runtime option. |
Any way you could still get this merged in? :) |
The options I'm referring to is |
Ah ok yeah, that makes sense. For me Any possibility of geteting this merged in @gregberge? Or do you recommend an alternative route? My comments were in #653 |
Hi @gregberge, just checking-in again to see if this is something you'd possibly consider to merge in? |
Simplifies the fix for #653, and should hopefully smooth things over for people not using babel in their projects