Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the compilation warning level and rename the default build configuration #2

Closed
gregbreen opened this issue Nov 4, 2018 · 1 comment
Assignees

Comments

@gregbreen
Copy link
Owner

By default, the warning level is low. Turn it up, fix easy warnings, disable a handful that are too hard to fix in SiLabs' code.

I also don't lile the default build configuration name of "GNU ARM v7.2.1 - Default". I understand where it comes from, but I prefer the decades old tried and true Debug and Release.

Create a Debug build configuration, with optimization O0. Also define DEBUG macro constant for that build configuration.

@gregbreen
Copy link
Owner Author

Like the Thunderboard React, turning on Wextra produced some warnings in Silicon Labs code. Changes here: https://github.com/gregbreen/uncannier-thunderboard-sense2/pull/3/files

Selecting disabled Wunused-parameter because there were too many of them.

-Wconversion and -pendatic also produced too many warnings to enable those.

Note that advertisingIteration() in radio_ble.c already has a DEBUG guard around the EM4 shutdown mode. So the Debug build configuration will never enter EM4 shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant