Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Some opinions #1

Open
shunjikonishi opened this issue Aug 2, 2013 · 0 comments
Open

Some opinions #1

shunjikonishi opened this issue Aug 2, 2013 · 0 comments

Comments

@shunjikonishi
Copy link

Hi,
I've test this buildpack. It works. Good job!

I have some opinions to this buildpack.
Please consider them.

Error of usage

You wrote followings in README.md

$ cat .buildpacks
https://github.com/heroku/heroku-buildpack-toolbelt.git

But its url is not correct. Correct url is

https://github.com/gregburek/heroku-buildpack-toolbelt.git

How to authentication

You use HEROKU_TOOLBELT_API_EMAIL and HEROKU_TOOLBELT_API_PASSWORD to run heroku command.

But I think HEROKU_API_KEY is better than them.
I've verified run it with HEROKU_API_KEY and without HEROKU_TOOLBELT_API_EMAIL and HEROKU_TOOLBELT_API_PASSWORD

In this case, maybe gen-netrc.sh is not neccessary.

Export path to heroku command.

I hope to run command without path to bin.

I've been implemented this feature in other buildpack.

https://github.com/shunjikonishi/heroku-buildpack-ffmpeg/blob/master/bin/compile

You can do it by using .profile.d

Best

Shunji Konishi

mikehale pushed a commit to mikehale/heroku-buildpack-cli that referenced this issue Jun 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant