Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integer conversion and depth problem with nuke3DL #8

Closed
illuminascent opened this issue Oct 23, 2018 · 1 comment
Closed

integer conversion and depth problem with nuke3DL #8

illuminascent opened this issue Oct 23, 2018 · 1 comment

Comments

@illuminascent
Copy link

illuminascent commented Oct 23, 2018

I was getting pylut 1.4.9 via pycharm venv, and works under python 3.6.5.
I have converted old print and xrange statements to python 3 version.

It seems that all of the From and To methods suffer from improper indices now, where they should be floored but was left as float. Since numpy no longer support float indices, I guess encapsulating with a int() will solve the problem.

Also I was trying this module with photoshop original LUTs, some nuke3DL file has entries that goes up to 12-bit color depth, but the first row ends with 1023, which by the FromNuke3DLFile() method should imply 10-bit depth and will lead to a lattice being 4 times brighter than the file was originally intended.
I think the correct outputDepth should actually be +2, but am not sure whether it is a common problem or not.

@gregcotten
Copy link
Owner

The integer problem was fixed in #7 but I no longer maintain pylut and have not updated the pip version since the fix. I have encountered this 3DL problem when designing Lattice and had to make some assumptions based on max values found in the LUT. Not all manufacturers respect 3DLs the same way, and honestly no one should be using them anymore anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants