Fixed an issue in ColorAtInterpolatedLatticePoint Function where inde… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x values become float In ColorAtInterpolatedLatticePoint Function, the index values lowerRedPoint, upperRedPoint, lowerGreenPoint, upperGreenPoint, lowerBluePoint, upperBluePoint sometimes becoming float values such as 15.0. So I converted those values to int type. After doing so, the issue posted by user Junnu123 "Error Combining LUT" is also resolved .
|
I know it’s petty, but if I could convince you to put a single space on both sides of the equals sign and no space between the int and the parentheses I will approve this pull request! |
|
Just going to mention #6 to link it with the issue. |
|
Looks great! Thanks so much. |
|
You are welcome. I appreciate your effort in obtaining various LUT format specifications and implementing various operations on them (whose information is rarely available on the Internet). If I have time, I will try to implement conversion of other LUT formats and submit a Pull Request. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x values become float
In ColorAtInterpolatedLatticePoint Function, the index values lowerRedPoint, upperRedPoint, lowerGreenPoint, upperGreenPoint, lowerBluePoint, upperBluePoint sometimes becoming float values such as 15.0. So I converted those values to int type.
After doing so, the issue posted by user Junnu123 "Error Combining LUT" is also resolved .