Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CubemapReadyCallback called with wrong parameters order #74

Closed
mserege opened this issue Jan 5, 2018 · 2 comments
Closed

CubemapReadyCallback called with wrong parameters order #74

mserege opened this issue Jan 5, 2018 · 2 comments

Comments

@mserege
Copy link

mserege commented Jan 5, 2018 •
edited
Loading

Hi,

FYI, loadCubemapFromUrls method calls a its callback with wrong parameters order.

callback(errors.length ? errors : undefined, imgs, tex); should be
callback(errors.length ? errors : undefined, tex, imgs); as defined in CubemapReadyCallback definition.

Same thing with loadSlicesFromUrls method and ThreeDReadyCallback definition.
@greggman
Copy link
Owner

greggman commented Jan 6, 2018

thanks. Fixed in 4.4.0?

@mserege
Copy link
Author

mserege commented Jan 6, 2018

Yes. Perfect!

@mserege mserege closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greggman @mserege