Add entity translation support #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdrianGarside Looks good to me, however there are quite a few changes to get the translation in and didn't want this to impact you might have been working on. You OK to review and merge if happy? |
There was a problem hiding this comment.
What do we need to do as/when we add new translatable strings - do we need to duplicate them (untranslated / online translated) into the fr.json file or is it ok to just add them to the en.json file and it'll automatically use them until someone (like yourself) adds the missing translations?
| name="Cooling Fan", | ||
| value_fn=lambda device: device.fans.cooling_fan_speed | ||
| translation_key="cooling_fan", | ||
| value_fn=lambda device: device.fans.cooling_fan_speed, |
There was a problem hiding this comment.
I think, but am not sure, that this extra comma will cause problems? But maybe not if this is running fine for you as-is. But it is inconsistent with the other code in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add translation support to any entity following Home Assistant documentation.
Translations
strings.jsonhas been deleted because it's not needed for custom components. Onlyen.jsonis useful.Translation keys has been added to any entities.
I also added french translations as it's my native language.
Entity options
optionshas been added to current stage, speed profile and printing speed to add autocompletion in automation editor and translations.Lowercasing string value
Unknownhas been changed tounknownso it can be translated too.Speed value has be converted to lowercase to support translations too.
Device class for online entity
Online entity has been changed to running instead of power because power is for electricity power detection not device power on.
Feel free to give any feedback if you find something strange or wrong.