Wiki link incorrect for non AMS related errors #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I had noticed I'd caused this but hadn't got around to seeing what I messed up. |
AdrianGarside
added a commit
that referenced
this pull request
Jan 9, 2024
* Update version: * Miscellaneous features and cleanup. (#404) * Get cloud start time on startup w/ bambu credentials * Improve logging * Add nozzle type and diameter sensors * Split PrintJob class out of Info class * Minor fix * Remove duplicated line * Improve chamber image logging * Update release notes * Add beginning of localization support for printbed_type * Add homeflag support * Fixes * Cleanup * Add door open sensor for X1 * Adjust door sensor name * Fix mqtt home_flag parsing * Update release notes * Update README * Fix typos * Add back version check for X1 but working * Add reconnection logic to chamber image thread * Convert match/switch statements to if/elif for compatibility with early python versions * Improve start/end time handling on integration start * Added unit of measurement for nozzle diameter (#410) * Fix incorrect HMS error code (#409) * Move comment. * Fix nozzle diameter syntax errors * Fix version * Expand release notes --------- Co-authored-by: Frank Meus <frank.meus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMS errors not related to the AMS are being regarded as being AMS related and thus were made generic.
Now the same method is followed as in get_HMS_error_text (check if error is part of HMS_AMS_ERRORS).