-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scrollbars #13
Fix scrollbars #13
Conversation
I finally had some time to review the things. As I see, you still don't need to use reflections nor custom classes. Calling
|
You're right! I've fixed it now. |
I wish we could just enable vertical scrollbars from code instead of using custom styles for that. I was trying to debug the process of initializing scrollbars in a |
If I remember correctly, it's easier to disable scrollbars than to enable them in code because of a bug. EDIT: Found it. |
…reference-V7-Fix Update to 23.2.0. Conflicts: app/src/main/java/android/support/v7/preference/PreferenceFragmentCompatFix.java
Is this really needed? Even the Settings in Android has no scrollbars (at least on my HTC). |
@Gericop There is one on my Lineage OS 14.1. |
Checked this, the Java modification is not needed anymore, the scrollbars automatically show up and fade away with the XML only. If I can create a solution such that the scrollbars can be turned on / off with a single XML attribute, I'll add it to the styles. |
I don't think it hurts to have a scrollbar. |
I would like to have a scrollbar too, Settings on Android 8.0 (Nexus 5X) has a scrollbar. |
Scrollbars enabled in v27.0.0.0 |
This solution is based on NeoSpb's (see #12). Yet simpler and more flexible I think.
I haven't thoroughly tested this but it should work and you should get the idea. 😄