Add a :print-fallback key to *options* to fall back on pr-str #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `:print-fallback` key (default false) to the puget.printer/*options* map. Setting the value to true will cause Puget to fall back on an object's `pr-str` value rather than printing its class information.
| @@ -121,7 +126,7 @@ | |||
|
|
|||
|
|
|||
| (defn- illegal-when-strict! | |||
| "Throws an exception if strict mode is enabled. The error indincates that the | |||
| "Throws an exception if strict mode is enabled. The error indicates that the | |||
This moves `:print-fallback` from being a simple boolean to taking a keyword value, which is checked as part of a case statement in `unknown-document`
| @@ -35,6 +35,11 @@ | |||
| The text placed between a map key and a collection value. The keyword :line | |||
| will cause line breaks if the whole map does not fit on a single line. | |||
|
|
|||
| `:print-fallback` | |||
| Takes a keyword argument specifying the desired string representation of | |||
| uknown documents. The keyword :print will fall back to using `pr-str` | |||
There was a problem hiding this comment.
Typo: 'uknown' should be 'unknown'. Also, put backticks around :print.
|
Nice, this looks better. One more minor comment and we're good to go. |
1 similar comment
greglook
added a commit
that referenced
this pull request
Feb 27, 2015
Add a :print-fallback key to *options* to fall back on pr-str
|
Any thoughts on when we might see this percolate up to Whidbey? |
|
I'll release 0.7.1 in the next day or two. |
|
Released whidbey 0.5.1 with a dependency on puget 0.7.1. |
|
Fantastic! Thanks so much :) I should have a release for Ultra (likely 0.3.0) in the next day or so as well. |
|
No problem, thanks for the contribution. 👍 Ultra has certainly been good exposure for puget and whidbey. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
:print-fallbackkey (default false) to thepuget.printer/options map. Setting the value to true will cause Puget
to fall back on an object's
pr-strvalue rather than printing itsclass information.
I believe this should resolve venantius/ultra#8 once the dependency graph for Whidbey has also been updated.