Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printer Dispatch Overhaul #24

Merged
merged 26 commits into from
Oct 13, 2015
Merged

Printer Dispatch Overhaul #24

merged 26 commits into from
Oct 13, 2015

Conversation

greglook
Copy link
Owner

@brandonbloom @gfredericks

Thoughts on these changes? This upgrades to Clojure 1.7 and the new fipp visitor pattern. The IVisitor protocol replaces much of what used to be the format-doc multimethod, and the remaining special-cases are handled using an explicit dispatch mechanism for finding handlers. This removes the need for the puget.data code and import-time modifications to the global protocol/multimethod tables.

I also extracted the puget.order code into a separate micro-lib named mvxcvi/arrangement.

Addresses issues #21, #23, and indirectly #22.

Greg Look and others added 26 commits October 7, 2015 17:43
Update dependencies and switch to arrangement.
4f31a76
Initial attempt to upgrade to fipp visitor pattern.
0161cad
Move options into PugetPrinter and feed explicitly to color-doc.
874e786
Fix some compilation errors.
fdf374a
Fix more compilation errors in printer, update printer tests.
96a9868
Add initial take on dispatch functions.
76b073e
@greglook
Implement inheritance-lookup.
085ea82
@greglook
Use printer properties instead of dynamic options.
e22b2b1
@greglook
Add tests for dispatch functions.
3f83af2
@greglook
Rename render to render-to-out to avoid confusion.
a684761
@greglook
Rename sort-keys option to sort-mode.
c7ae2ee
@greglook
Rewrite formatting handlers to use format-doc for recursion.
a48016e
@greglook
Inline system-id and move order-collection.
67a5776
@greglook
Change clojure types into handler functions.
04a96ee
@greglook
Remove data namespace.
9803b3f
@greglook
Fix some compilation and test errors.
10f7366
@greglook
Split out format-doc* to better handle metadata.
1618838
@greglook
Split out java-handlers and use dispatch method to compose common-han…
069e1d5 
…dlers.
@greglook
Fix tests.
ec9a711
@greglook
Add symbolic-lookup dispatch and test.
7a55094
@greglook
Expand print-fallback tests.
8fe631d
@greglook
Fix bug in dispatch/lineage.
062fd0f
@greglook
Default :print-handlers to common-handlers.
ac17e0e
@greglook
Use case instead of cond in visit-unknown.
2539d1a
@greglook
A few doc updates.
ce82416
@greglook
Factor out render-str function.
f7e3f92
@brandonbloom
Copy link
Contributor

This all seems reasonably sane to me, but I haven't studied the code super closely.

Thanks for taking on this work!

@gfredericks
Copy link

reading the new docs and glancing at the code, it seems like it should be sufficient for #23. 👍

greglook added a commit that referenced this pull request Oct 13, 2015
@greglook
Merge pull request #24 from greglook/clojure17
0211aaa 
Printer Dispatch Overhaul
@greglook greglook merged commit 0211aaa into develop Oct 13, 2015
@greglook
Copy link
Owner Author

Thanks for looking it over guys!

@greglook greglook deleted the clojure17 branch October 13, 2015 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greglook @brandonbloom @gfredericks