Allow colors to be disabled via :puget-options #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue greglook#8. This wasn't possible because whidbey hard-coded a call to `cprint-str` rather than using `pprint-str` with a default option of `{:print-color true}`.
gfredericks
force-pushed
the
color-turnoffability
branch
from
2b9b049
to
c403d7c
Compare
|
Originally referenced the wrong issue (not sure how I pulled that off), and force-pushed to correct it. |
|
Looks good to me! Thanks for patching this, it's exactly what I had in mind. I'll test it out locally and release a new version of whidbey later. |
greglook
added a commit
that referenced
this pull request
Sep 24, 2014
Allow colors to be disabled via :puget-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #8.
This wasn't possible because whidbey hard-coded a
call to
cprint-strrather than usingpprint-strwith a default option of
{:print-color true}.