Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache_page(per-page-cache) is not working correctly. #41

Closed
amrael opened this issue Jun 18, 2014 · 1 comment
Closed

cache_page(per-page-cache) is not working correctly. #41

amrael opened this issue Jun 18, 2014 · 1 comment

Comments

@amrael
Copy link

amrael commented Jun 18, 2014

I've integrated django-mobile into my website along with Django Cache enabled but I noticed that the per-page-cache were not read and the framework sends database queries even though the pages exist in cache.

After some investigation, I found out that the issue was caused by cache_page and CacheFlavourMiddleware not taking into account the sequence of the cache process.

Expected Sequence:
Set "HTTP_X_FLAVOUR" header -> FetchFromCacheMiddleware -> Set "Vary: X-Flavour" header -> UpdateCacheMiddleware

Current Sequence:
FetchFromCacheMiddleware -> Set "HTTP_X_FLAVOUR" header -> Set "Vary: X-Flavour" header -> UpdateCacheMiddleware

So FetchFromCacheMiddleware always looks for invalid cache.
amrael pushed a commit to amrael/django-mobile that referenced this issue Jun 18, 2014
Fix gregmuellegger#41
4ca5521
@amrael
Copy link
Author

amrael commented Jun 18, 2014

pull request #42

@amrael amrael closed this as completed Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amrael