make set_flavour work with permanent=False #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_flavour was always checking the flavour_storage first, so if set_flavour was called with permanent=False to set the flavour on the request but not the flavour_storage, get_flavour was not affected. Change to make get_flavour check the request first, and then the flavour_storage.
|
Needs more work to be fully functional - closing and will open a new PR when appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_flavourwas always checking theflavour_storagefirst, so ifset_flavourwas called withpermanent=Falseto set the flavour on the request but not theflavour_storage,get_flavourwas not affected. Change to makeget_flavourcheck the request first, and then theflavour_storage.