Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst accordingly to Django 1.9 #66

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

prokaktus
Copy link
Contributor

Hi!

TEMPLATE_LOADERS and TEMPLATE_CONTEXT_PROCESSORS deprecated and removed in Django 1.9.

@gregmuellegger
Copy link
Owner

Thanks for the addition, however I think that will break the description for old Django versions. It's not too big of a deal, since Django 1.8 is the only maintained LTS version at the moment and it already has the new TEMPLATES setting.

A change request to your pull request 😉

Add after the list of steps:

.. note: If you are using Django 1.7 or older, you need to change step 5 and 6 slightly. Use the ``TEMPLATE_LOADERS`` and ``TEMPLATE_CONTEXT_PROCESSORS`` settings instead of ``TEMPLATES``.

@prokaktus
Copy link
Contributor Author

prokaktus commented Jul 14, 2016

Just find SO-question about Django 1.9 compatibility. Because of settings, I think.
http://stackoverflow.com/questions/37083195/how-do-i-check-if-a-user-is-using-a-mobile-device-in-django-1-9/

@gregmuellegger gregmuellegger merged commit d517c6f into gregmuellegger:master Jul 19, 2016
@gregmuellegger
Copy link
Owner

Oh I haven't noticed you have added the line I have suggested. Thanks for the nudge, I've merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants