Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load configuration from .active_record_doctor.rb #166

Merged
merged 1 commit into from Dec 8, 2023

Conversation

gregnavis
Copy link
Owner

This commit changes the default configuration file, so that text editors recognize it as a Ruby file. The old file is still supported but a warning is shown whenever it's used.

@fatkodima
Copy link
Contributor

Not a big deal, but can you add co-authors where appropriate when closing PRs?
@jdufresne implemented the closest version to this PR.

Copy link
Contributor

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

@gregnavis
Copy link
Owner Author

@fatkodima, thank you for bringing this up. This IS a big deal to me, as it's important for me to give credit where it's due. Let me update the PR ...

This commit changes the default configuration file, so that text editors
recognize it as a Ruby file. The old file is still supported but a
warning is shown whenever it's used.

Co-authored-by: Jon Dufresne <jon.dufresne@gmail.com>
@gregnavis gregnavis force-pushed the add-rb-to-default-config-file branch from 509db4a to 4476ac0 Compare December 8, 2023 11:32
@gregnavis
Copy link
Owner Author

@fatkodima, @jdufresne, done!

image

@gregnavis gregnavis merged commit dd1ad30 into master Dec 8, 2023
122 checks passed
@gregnavis gregnavis deleted the add-rb-to-default-config-file branch December 8, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants