Merge pull request #995 from bkiac/fix-on-column-sort-change-label

Refactor column direction conversion
gregnb · Jun 2, 2020 · d942865 · d942865
2 parents 1a3abe3 + 8a37936
commit d942865
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/MUIDataTable.js b/src/MUIDataTable.js
@@ -938,7 +938,7 @@ class MUIDataTable extends React.Component {
     );
   };
 
-  getSortDirection(column) {
+  getSortDirectionLabel(column) {
     return column.sortDirection === 'asc' ? 'ascending' : 'descending';
   }
 
@@ -966,7 +966,7 @@ class MUIDataTable extends React.Component {
           }
         }
 
-        const orderLabel = this.getSortDirection(columns[index]);
+        const orderLabel = this.getSortDirectionLabel(columns[index]);
         const announceText = `Table now sorted by ${columns[index].name} : ${orderLabel}`;
 
         let newState = {
@@ -1001,7 +1001,7 @@ class MUIDataTable extends React.Component {
         if (this.options.onColumnSortChange) {
           this.options.onColumnSortChange(
             this.state.columns[index].name,
-            this.getSortDirection(this.state.columns[index]),
+            this.state.columns[index].sortDirection,
           );
         }
       },