We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With irrelevant options elided, this:
<MUIDataTable title={title} columns={columns} options={{ textLabels: { noMatch: <CircularProgress size={24} style={{marginLeft: 15, position: 'relative', top: 4}} />, } noMatchTypographyComponent: "div", }} data={tableRows} />
Results in this when there are no matches:
<Typography component="div"> <CircularProgress size={24} style={{marginLeft: 15, position: 'relative', top: 4}} /> </Typography>
Which gives us a structure like:
<div> <div>…</div> </div>
Which, while a little unnecessary, is valid.
<Typography> <CircularProgress size={24} style={{marginLeft: 15, position: 'relative', top: 4}} /> </Typography>
Because Material UI’s CircularProgress wraps its contents in a div, this gives us a structure like:
CircularProgress
div
<p> <div>…</div> </p>
Which causes a DOM nesting validation error.
The text was updated successfully, but these errors were encountered:
Thank you for the report. I've put a fix for this in v3.2.0, which should come out next week and is available in beta here:
npm install mui-datatables@v3.2.0-beta.0
Sorry, something went wrong.
That was so quick! Thank you very much.
Fixed in version 3.2.0
No branches or pull requests
Expected Behavior
With irrelevant options elided, this:
Results in this when there are no matches:
Which gives us a structure like:
Which, while a little unnecessary, is valid.
Current Behavior
With irrelevant options elided, this:
Results in this when there are no matches:
Because Material UI’s
CircularProgress
wraps its contents in adiv
, this gives us a structure like:Which causes a DOM nesting validation error.
Your Environment
The text was updated successfully, but these errors were encountered: