Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mui-datatables v3.2.0 #1404

Merged
merged 39 commits into from
Jul 16, 2020
Merged

mui-datatables v3.2.0 #1404

merged 39 commits into from
Jul 16, 2020

Conversation

patorjk
Copy link
Collaborator

@patorjk patorjk commented Jul 10, 2020

Branch for the 3.2.0 release of mui-datatables. It contains the following:

A beta version is available via:

npm install mui-datatables@v3.2.0-beta.2

Currently a work in progress, will probably be released next week.

@coveralls
Copy link

coveralls commented Jul 10, 2020

Coverage Status

Coverage increased (+1.3%) to 72.375% when pulling 9c2d14d on v3_2_0 into efd5f1e on master.

@@ -1,9 +1,14 @@
import Chip from '@material-ui/core/Chip';
import PropTypes from 'prop-types';
import React from 'react';
import classnames from 'classnames';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you accept a PR to replace classnames with clsx? Only suggesting because I learned today that @material-ui/core uses clsx.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished looking into it (mui/material-ui#14152). Smaller, faster, same API, and Material UI switched from classnames to clsx. I'd would accept a PR for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants