Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Table and View Columns icons are not working after upgrading to 2.1.0 (from 2.0.0) #600

Closed
hrmoller opened this issue May 8, 2019 · 6 comments · Fixed by #606
Closed
Assignees
Labels

Comments

@hrmoller
Copy link

hrmoller commented May 8, 2019

Expected Behavior

View columns and filter table as wanted.

Current Behavior

When clicking the icon(View Columns & Filter Table) nothing happens. Search and Download icons works just fine.

Screenrecording:
https://www.dropbox.com/s/h9i449od9tlcowy/Screen%20Recording%202019-05-08%20at%2013.58.37.mov?dl=0

Steps to reproduce

  1. Upgrade mui-datatables to version 2.1.0
  2. Start app
  3. When View Columns selector and Filter Table are clicked nothing happens

Your Environment

I'm using a react app based on create-react-app running on node 10.15.3.

Tech Version
Material-UI 3.9.3
MUI-datatables 2.1.0
React 16.8.1
browser Crome & Safari
etc MacOS Latest
@hrmoller hrmoller changed the title Filter and Columns Filter Table and View Columns icons are not working after upgrading to 2.1.0 May 8, 2019
@hrmoller hrmoller changed the title Filter Table and View Columns icons are not working after upgrading to 2.1.0 Filter Table and View Columns icons are not working after upgrading to 2.1.0 (from 2.0.0) May 8, 2019
@cherukumilli
Copy link

I see the same error. Here is a link to codesandbox example for the same:
https://codesandbox.io/s/rj37ykw26m?fontsize=14

@gabrielliwerant
Copy link
Collaborator

gabrielliwerant commented May 8, 2019

Later versions of material-ui introduce breaking changes. I'm working on upgrading it, but it's complicated, so it may not be done for a bit.

image

In the mean time, I recommend using material packages that are no larger than the versions used by this library. In the code sandbox example above, if I change package versions to @material-ui/core: 3.2.2 and @material-ui/icon: 3.0.2, the buttons work as expected.

@bndynet
Copy link
Contributor

bndynet commented May 10, 2019

The same case, I have downgraded to version 2.0.0. Waiting for the newest version for fixing it.

@SkyTradeInc
Copy link

Same case here too

@gabrielliwerant
Copy link
Collaborator

There is a PR up that should fix this particular issue, so stay tuned.

@rodriigovieira
Copy link

Got the same error here, with the MaterialUI 4 beta. Made the downgrade to 2.0.0 and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants