Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issues 561 and 600 toolbar problems #606

Merged
merged 4 commits into from
May 16, 2019

Conversation

gabrielliwerant
Copy link
Collaborator

Closes #600 and #561.

  • Issue 600: On later versions of material-ui, React.cloneElement fails to properly apply necessary props, which results in the certain toolbar options that do not have their necessary onClick props.
  • Issue 561: Various tooltips persisted after closing their respective popovers, but is now fixed by using the disableFocusListener prop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.049% when pulling ee3c4dc on bugfix/issues-561-600-toolbar-issues into 267c4cd on master.

@gregnb
Copy link
Owner

gregnb commented May 14, 2019

hey @gabrielliwerant I left you a message on the private repo discussion you created if you have a moment. Thank you

@gabrielliwerant
Copy link
Collaborator Author

Hey @gregnb, I opened an issue in that repo for some further discussion. Let me know if you have trouble finding it, but you should have access.

@gabrielliwerant gabrielliwerant merged commit d0b7546 into master May 16, 2019
@gabrielliwerant gabrielliwerant deleted the bugfix/issues-561-600-toolbar-issues branch May 16, 2019 05:33
bzemms added a commit to dome9/mui-datatables that referenced this pull request Jun 2, 2019
* master:
  2.3.0
  Update package lockfile and prettify files
  Allow search bar to be shown when switching between toolbars (gregnb#654)
  Improve grid spacing in filters dialog (gregnb#640)
  fix renderMultiselect filter type for null values (gregnb#624)
  add onTableInit callback (gregnb#622)
  Bugfix/remove deprecated rollup config option (gregnb#641)
  Bugfix/search text issues (gregnb#647)
  Bugfix/issue 587 fix duplicate call (gregnb#631)
  Single grid column for single filter (gregnb#613)
  header wrap fix (gregnb#629)
  published version 2.2.0
  Add documentation for how to hide column from 'View column' list (gregnb#43) (gregnb#609)
  Bugfix/issues 561 and 600 toolbar problems (gregnb#606)
  Add searchText option to initialise datatable with search text (gregnb#603)
  customRowRender (gregnb#589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Table and View Columns icons are not working after upgrading to 2.1.0 (from 2.0.0)
3 participants