Bugfix/issue 1005 prevent page reset on search close #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to branch the functionality so we can more easily assign different behavior for closing the search bar
gabrielliwerant
deleted the
bugfix/issue-1005-prevent-page-reset-on-search-close
branch
wuhuizuo
pushed a commit
to wuhuizuo/mui-datatables
that referenced
this pull request
Oct 22, 2019
* Use new method of updating when closing search bar This allows us to branch the functionality so we can more easily assign different behavior for closing the search bar * Update toolbar test to accommodate search close function * Add test for search close functionality not reseting page * Add test for reseting search text on search bar close * Prettify files
wuhuizuo
pushed a commit
to wuhuizuo/mui-datatables
that referenced
this pull request
Oct 22, 2019
* Use new method of updating when closing search bar This allows us to branch the functionality so we can more easily assign different behavior for closing the search bar * Update toolbar test to accommodate search close function * Add test for search close functionality not reseting page * Add test for reseting search text on search bar close * Prettify files
waqasajaz
pushed a commit
to waqasajaz/mui-datatables
that referenced
this pull request
Oct 31, 2019
* Use new method of updating when closing search bar This allows us to branch the functionality so we can more easily assign different behavior for closing the search bar * Update toolbar test to accommodate search close function * Add test for search close functionality not reseting page * Add test for reseting search text on search bar close * Prettify files
lalong13
pushed a commit
to lalong13/mui-datatables
that referenced
this pull request
Jan 15, 2020
* Use new method of updating when closing search bar This allows us to branch the functionality so we can more easily assign different behavior for closing the search bar * Update toolbar test to accommodate search close function * Add test for search close functionality not reseting page * Add test for reseting search text on search bar close * Prettify files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1005