Fix for 737 #738
Merged
Fix for 737 #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabrielliwerant Found a small issue with the custom filter stuff. |
|
Ok, so if I'm understanding correctly, this is an issue with the way the example was constructed? It looks like the example should not have been using arrays in way that it was, which I missed when I reviewed it. And this PR is a fix for that? |
|
Yep, this would just be fixing the example to be correct. |
gabrielliwerant
added
the
needs review
gabrielliwerant
approved these changes
Aug 1, 2019
gabrielliwerant
added
lgtm
enhancement
and removed
needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #737