Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with width on custom filter component #791

Merged
merged 4 commits into from
Aug 9, 2019
Merged

Fix issue with width on custom filter component #791

merged 4 commits into from
Aug 9, 2019

Conversation

pkmnct
Copy link
Contributor

@pkmnct pkmnct commented Jul 24, 2019

Fix #790

@coveralls
Copy link

coveralls commented Jul 24, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 75.972% when pulling 7d86d0f on pkmnct:patch-1 into 6e973d2 on gregnb:master.

@gabrielliwerant
Copy link
Collaborator

Hm, not sure I see how this relates to custom filters. Custom filters are rendered using the renderCustomField method, not the renderSelect method. What are your filterOptions?

@pkmnct
Copy link
Contributor Author

pkmnct commented Jul 26, 2019

@gabrielliwerant You are correct. It turns out this was an issue on my implementation. I've closed the issue and PR!

@pkmnct pkmnct closed this Jul 26, 2019
@pkmnct pkmnct reopened this Jul 26, 2019
@pkmnct
Copy link
Contributor Author

pkmnct commented Jul 26, 2019 •
edited
Loading

@gabrielliwerant Ignore my prior comment. I did some more research on this, and I figured out what was causing the weirdness. The FormControl components for the Select and TextField filter options had a style that did the equivalent of the fullWidth prop. I've removed this style and used fullWidth on all of the FormControls that had used it, in addition to the one for the custom filter type.

@gabrielliwerant gabrielliwerant added the needs review Useful to mark PRs for what's up next to review label Aug 1, 2019
@gabrielliwerant gabrielliwerant self-requested a review August 1, 2019 06:01
gabrielliwerant
gabrielliwerant approved these changes Aug 8, 2019
View reviewed changes
Copy link
Collaborator

@gabrielliwerant gabrielliwerant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It's nice to get rid of those extra divs, thanks for chipping in!

@gabrielliwerant gabrielliwerant added lgtm and removed needs review Useful to mark PRs for what's up next to review labels Aug 8, 2019
@gabrielliwerant gabrielliwerant merged commit aaf8dac into gregnb:master Aug 9, 2019
@gabrielliwerant gabrielliwerant mentioned this pull request Aug 9, 2019
Closed
@pkmnct pkmnct mentioned this pull request Aug 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielliwerant gabrielliwerant gabrielliwerant approved these changes

Assignees
No one assigned
Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Width on custom filter component
3 participants
@pkmnct @coveralls @gabrielliwerant