Fixes for 676 and 595 #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielliwerant
added
the
needs review
gabrielliwerant
approved these changes
Aug 28, 2019
gabrielliwerant
added
enhancement
lgtm
and removed
needs review
|
Your help is greatly appreciated. The library is getting to the point where it's too large for a single maintainer, so these kinds of contributions are exactly what's needed. Additionally, the codesandbox was super helpful in allowing quick verification. Please keep up the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#676 - Made compatible with MUI v3 or v4.
#595 - Removed warning by following the suggestion of @mib00038.
Quick view of the changes available here: https://codesandbox.io/s/github/patorjk/mui-datatables/tree/676_595
I'm a huge fan of this library and am using it pretty extensively with v4. Hopefully I'm not being too annoying with all the PRs, I just have some extra time this week.