Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kindly Update to use latest node, npm and yarn version(s) #71

Closed
jermsam opened this issue Nov 21, 2018 · 7 comments
Closed

Kindly Update to use latest node, npm and yarn version(s) #71

jermsam opened this issue Nov 21, 2018 · 7 comments

Comments

@jermsam
Copy link

jermsam commented Nov 21, 2018

On trying to install dependency, I get:

error tav-r@1.0.0: The engine "node" is incompatible with this module. Expected version "10.11.0". Got "10.13.0" error tav-r@1.0.0: The engine "yarn" is incompatible with this module. Expected version "1.10.1". Got "1.12.3" error Found incompatible module

@jermsam jermsam changed the title Kindly Update to use latest node, npm and yarn version Kindly Update to use latest node, npm and yarn version(s) Nov 21, 2018
@MatthewHerbst
Copy link
Owner

Hi @jermsam. This library does not use any engines directives in its package.json, so those errors are not coming from here. Further, this library does not use Yarn. Are you sure the error you are getting is when you are installing this library? If so, can you please show the install command you are running and the entire error log? Thanks!

@jermsam
Copy link
Author

jermsam commented Nov 22, 2018

Hi @MatthewHerbst, Yes. Installing the library generates the error log highlighted above. I had to downgrade my node and yarn to the suggested to have it working. I needed to use the library ASAP so i did not wait for the issue to be resolved. Reason I downgraded, ... After downgrading it worked awesomely, however I think it would be better off being compatible with any node versions.

@MatthewHerbst
Copy link
Owner

@jermsam as far as I am aware, we are compatible with all node and npm/yarn versions. There's nothing in this library's package.json that I know about that could impact not working with node or npm/yarn versions. In fact, the package that your error message shows as throwing on, tav-r, doesn't even exist in our package-lock.json file, which shows everything that will get installed when you install this library.

Can you please post the entire command you run to install, plus the entire error message after it?

@jermsam
Copy link
Author

jermsam commented Nov 22, 2018

The entire error message was that above. The command to install is this below:

yarn add react-to-print

@MatthewHerbst
Copy link
Owner

I just created a branch new test library and installed this package without issue.

~/Desktop/test $ yarn add react-to-print
yarn add v1.12.3
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 5 new dependencies.
info Direct dependencies
└─ react-to-print@2.0.0-alpha-4
info All dependencies
├─ js-tokens@4.0.0
├─ prop-types@15.6.2
├─ react-to-print@2.0.0-alpha-4
├─ react@16.6.3
└─ scheduler@0.11.2
✨  Done in 2.03s.
~/Desktop/test $ node --version
v10.13.0
~/Desktop/test $ yarn --version
1.12.3

I think there must be something else you are doing. As I previously mentioned, there is absolutely nothing in this library that would cause an engines failure like you described.

Can you please rm -rf node_modules and then try installing it? Also, please show your full command line like I have done above. Thank you.

@jermsam
Copy link
Author

jermsam commented Nov 23, 2018

Thanks a lot. And again... am sorry. Just noticed it was my own package.json with engines directives that do not support the latest versions just as you mentioned before. I am closing this issue for that reason.

@jermsam jermsam closed this as completed Nov 23, 2018
@MatthewHerbst
Copy link
Owner

@jermsam glad you were able to figure it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants