Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute error #22

Merged
merged 5 commits into from
Apr 28, 2019
Merged

Fix attribute error #22

merged 5 commits into from
Apr 28, 2019

Conversation

osherdp
Copy link
Collaborator

@osherdp osherdp commented Apr 28, 2019

No description provided.

@coveralls
Copy link

coveralls commented Apr 28, 2019

Pull Request Test Coverage Report for Build 118

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 90.406%

Totals Coverage Status
Change from base Build 107: 1.8%
Covered Lines: 166
Relevant Lines: 186

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 114

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 90.406%

Totals Coverage Status
Change from base Build 107: 1.8%
Covered Lines: 166
Relevant Lines: 186

💛 - Coveralls

@@ -105,6 +105,11 @@ def start_debugging():
IPDBugger(exc_info=sys.exc_info()).set_trace(test_frame)


def get_value(ast_node):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super generic

excepted_types.extends([exception_type.id for exception_type
in handler.type.elts])
excepted_types.extend([exception_type for exception_type
in handler.type.elts])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the list creation

tests/utils.py Outdated


class TestError(Exception):
"""Exception class for the tests."""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain it must be external

@osherdp osherdp merged commit 9575734 into master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants