Check for illegal inputs #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build rotest 1.0.1368 failed (commit 09f48688e5 by @UnDarkle) |
|
❌ Build rotest 1.0.1370 failed (commit 4b1d12fa29 by @UnDarkle) |
osherdp
requested changes
Sep 10, 2019
src/rotest/core/block.py
Outdated
| @@ -174,3 +176,15 @@ def validate_inputs(self, extra_inputs=[]): | |||
| raise AttributeError("Block %r under %r is missing mandatory " | |||
| "inputs %s" % | |||
| (self.data.name, self.parent, missing_inputs)) | |||
|
|
|||
| def _is_valid_input(self, parameter_name): | |||
| """Check if the given parameter is a valid inputs for the component. | |||
src/rotest/core/flow_component.py
Outdated
| """Inject parameters into the component. | ||
|
|
||
| Args: | ||
| override_previous (bool): whether to override previous value of | ||
| the parameters if they were already injected or not. | ||
| validate_unknown (bool): check that all the parameters are legal. |
There was a problem hiding this comment.
I prefer just "all parameters are legal"
src/rotest/core/flow_component.py
Outdated
| """ | ||
| # The 'mode' parameter is only relevant to the current hierarchy | ||
| setattr(self, 'mode', parameters.pop('mode', self.mode)) |
There was a problem hiding this comment.
You can do self.mode = ...
No?
src/rotest/core/flow_component.py
Outdated
| @@ -430,6 +435,18 @@ def _set_parameters(self, override_previous=True, **parameters): | |||
| else: | |||
| setattr(self, name, value) | |||
|
|
|||
| if validate_unknown and not self._is_valid_input(name): | |||
There was a problem hiding this comment.
Maybe better naming it validate_unknown_inputs for clearer intentions
src/rotest/core/flow_component.py
Outdated
| Args: | ||
| parameter_name (str): parameter name to compare with input names. | ||
| """ | ||
| pass |
There was a problem hiding this comment.
Raise NotImplementedError
|
❌ Build rotest 1.0.1372 failed (commit 43b2a8ce0c by @gregoil) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.