Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate create sub resources #93

Merged
merged 28 commits into from Oct 16, 2018
Merged

Automate create sub resources #93

merged 28 commits into from Oct 16, 2018

Conversation

UnDarkle
Copy link
Collaborator

No description provided.

@UnDarkle UnDarkle changed the title Automated create sub resources Automate create sub resources Sep 12, 2018
@coveralls
Copy link

coveralls commented Sep 12, 2018

Pull Request Test Coverage Report for Build 830

  • 51 of 51 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.29%

Totals Coverage Status
Change from base Build 803: 0.1%
Covered Lines: 3793
Relevant Lines: 4666

💛 - Coveralls

@AppVeyorBot
Copy link

Build rotest 1.0.722 completed (commit 6abe8b5987 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.728 failed (commit df73adaa1e by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.730 failed (commit cd382feeea by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.732 failed (commit ab83a1b528 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.734 failed (commit b5fdca888c by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.736 failed (commit 04f73c32af by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.738 failed (commit 8be21395e5 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.740 failed (commit 3bc32f938a by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.742 completed (commit 318d4f38b6 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.761 completed (commit 28c023b512 by @UnDarkle)

src/rotest/common/utils.py Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

Build rotest 1.0.800 completed (commit c4a5a3ed96 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.804 failed (commit 6141c4052b by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.806 failed (commit 537f0fc2a6 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.808 failed (commit 3b376457bc by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.810 failed (commit 0fc514c12b by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.812 failed (commit c46fe4941c by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.814 failed (commit f6333feb01 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.816 failed (commit 431f1b7c07 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.818 failed (commit 4b4e63b917 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.820 failed (commit 219f60f989 by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.822 completed (commit dd35069872 by @osherdp)

src/rotest/common/utils.py Outdated Show resolved Hide resolved

self.client.release_resources(resources=[resource])

def test_lock_alter_complex_resource_with_service(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the alter means?
Change to something clearer...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means "alternative way of making a resource complex"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have any recommendation?
if not, the docstring would have to do

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either composed as the resource is composed of its fields
or the full word alternative

@AppVeyorBot
Copy link

Build rotest 1.0.824 failed (commit e5803b588d by @osherdp)

@AppVeyorBot
Copy link

Build rotest 1.0.825 completed (commit e5803b588d by @osherdp)

@AppVeyorBot
Copy link

Build rotest 1.0.827 failed (commit 7dd2879cee by @UnDarkle)

@AppVeyorBot
Copy link

Build rotest 1.0.828 completed (commit 7dd2879cee by @UnDarkle)

@UnDarkle UnDarkle merged commit 59f3d5f into master Oct 16, 2018
@UnDarkle UnDarkle deleted the pretty_sub_resources branch October 16, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants