New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate create sub resources #93
Conversation
Pull Request Test Coverage Report for Build 830
💛 - Coveralls |
✅ Build rotest 1.0.722 completed (commit 6abe8b5987 by @UnDarkle) |
❌ Build rotest 1.0.728 failed (commit df73adaa1e by @UnDarkle) |
❌ Build rotest 1.0.730 failed (commit cd382feeea by @UnDarkle) |
❌ Build rotest 1.0.732 failed (commit ab83a1b528 by @UnDarkle) |
❌ Build rotest 1.0.734 failed (commit b5fdca888c by @UnDarkle) |
❌ Build rotest 1.0.736 failed (commit 04f73c32af by @UnDarkle) |
❌ Build rotest 1.0.738 failed (commit 8be21395e5 by @UnDarkle) |
❌ Build rotest 1.0.740 failed (commit 3bc32f938a by @UnDarkle) |
✅ Build rotest 1.0.742 completed (commit 318d4f38b6 by @UnDarkle) |
✅ Build rotest 1.0.761 completed (commit 28c023b512 by @UnDarkle) |
✅ Build rotest 1.0.800 completed (commit c4a5a3ed96 by @UnDarkle) |
❌ Build rotest 1.0.804 failed (commit 6141c4052b by @UnDarkle) |
❌ Build rotest 1.0.806 failed (commit 537f0fc2a6 by @UnDarkle) |
❌ Build rotest 1.0.808 failed (commit 3b376457bc by @UnDarkle) |
❌ Build rotest 1.0.810 failed (commit 0fc514c12b by @UnDarkle) |
❌ Build rotest 1.0.812 failed (commit c46fe4941c by @UnDarkle) |
❌ Build rotest 1.0.814 failed (commit f6333feb01 by @UnDarkle) |
❌ Build rotest 1.0.816 failed (commit 431f1b7c07 by @UnDarkle) |
❌ Build rotest 1.0.818 failed (commit 4b4e63b917 by @UnDarkle) |
❌ Build rotest 1.0.820 failed (commit 219f60f989 by @UnDarkle) |
✅ Build rotest 1.0.822 completed (commit dd35069872 by @osherdp) |
|
||
self.client.release_resources(resources=[resource]) | ||
|
||
def test_lock_alter_complex_resource_with_service(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the alter means?
Change to something clearer...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it means "alternative way of making a resource complex"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have any recommendation?
if not, the docstring would have to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either composed
as the resource is composed of its fields
or the full word alternative
❌ Build rotest 1.0.824 failed (commit e5803b588d by @osherdp) |
✅ Build rotest 1.0.825 completed (commit e5803b588d by @osherdp) |
❌ Build rotest 1.0.827 failed (commit 7dd2879cee by @UnDarkle) |
✅ Build rotest 1.0.828 completed (commit 7dd2879cee by @UnDarkle) |
No description provided.