Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testModule does not check inputs based on RunYear #149

Closed
goreaditya opened this issue Mar 1, 2018 · 0 comments
Closed

testModule does not check inputs based on RunYear #149

goreaditya opened this issue Mar 1, 2018 · 0 comments
Assignees
@goreaditya
Labels
bug
Milestone
Complete VERPAT m...

Comments

@goreaditya
Copy link
Collaborator

runModule has this functionality that when it is called with the option RunYear = "NotBaseYear" it only checks if the inputs in the GROUP = "Year" have values for all years except base year. testModule on the other hand does not have this functionality and fails any test if the inputs are not present for all years (base year + not base year). Should testModule check inputs based on the value passed to the parameter RunYear?
@bstabler bstabler added the bug label Mar 1, 2018
@bstabler bstabler added this to the Complete VERPAT migration milestone Mar 1, 2018
@bstabler bstabler assigned goreaditya and unassigned gregorbj Mar 14, 2018
goreaditya added a commit that referenced this issue Mar 14, 2018
@goreaditya
Modified module.R script to address issue #149
b1b712e 
A condition is added where the data specifications are checked.
The condition checks for the `RunFor` option and if it is set to `NotBaseYear`
then the data specifications are only checked for all the years except base year.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goreaditya goreaditya

Labels
bug
Projects
None yet
Milestone
Complete VERPAT migration
Development

No branches or pull requests
3 participants
@bstabler @gregorbj @goreaditya