Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems when final syllable has no notes #1205

Closed
eroux opened this issue Aug 15, 2016 · 7 comments
Closed

problems when final syllable has no notes #1205

eroux opened this issue Aug 15, 2016 · 7 comments
Assignees
Milestone

Comments

@eroux
Copy link
Contributor

eroux commented Aug 15, 2016

The following example:

\documentclass[a5paper, 12pt]{book}
\usepackage[autocompile]{gregoriotex}
\begin{document}
\gresetinitiallines{0}
\gabcsnippet{(c4) Ma(i)rí(kko>)a!(j.) R(::) Salve Mater.()}
\end{document}

produces the strange result:

buggregorio

I think this is because of the way \GreLastOfScore is handled...

@eroux
Copy link
Contributor Author

eroux commented Aug 15, 2016

(originally from this thread)

@henryso henryso changed the title problems when final syllable has no text problems when final syllable has no notes Aug 15, 2016
@eroux
Copy link
Contributor Author

eroux commented Aug 15, 2016

The problem disappears if \GreLastOfScore is not called before the bar, so I think it should probably not be output by gregorio in this case, but I'm not sure what the consequences would be on other edge cases... @henryso what do you think?

@henryso
Copy link
Contributor

henryso commented Aug 15, 2016

I'm not sure I'm the best person to opine on that, but I can try to make the change and see what tests it breaks. I take it this is for 5.0?

@eroux
Copy link
Contributor Author

eroux commented Aug 15, 2016

Well, I would prefer 4.2, but if you think this is too much, then 5.0 is fine

@henryso
Copy link
Contributor

henryso commented Aug 15, 2016

No, I can do it in 4.2, but the milestone is not set, so I wasn't sure.

@henryso
Copy link
Contributor

henryso commented Aug 15, 2016

From reading the description, I think this might conflict with #1116.

@henryso henryso added this to the 4.2 milestone Aug 15, 2016
@henryso henryso self-assigned this Aug 15, 2016
@henryso
Copy link
Contributor

henryso commented Aug 19, 2016

If the check is only for syllables that follow, this breaks (g) (Z), which would cause a dummy custos to be emitted at the end of the last line. As a result, I will check that there are no elements after the \GreLastOfScore element before suppressing it.

henryso added a commit to henryso/gregorio-test that referenced this issue Aug 19, 2016
@henryso henryso closed this as completed Aug 20, 2016
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Aug 22, 2016
* release-4.2:
  Update Version Number
  Suppressed \GreLastOfScore if only no-element syllables follow it. Fixes gregorio-project#1205.
  Cherry pick fc54014
  Bump Copyright year.
  Change package loading order to account for TeXLive 2016
  Cherry pick 54bc8b8
  Load PlainTeX version of xstring
  Cherry pick ca8b226
  Update Version number
  CHANGELOG entries
  Fix issue with custom spaces
  Reach the translation glyph node by traverse_id()
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Sep 18, 2016
* release-4.2:
  Update Version Number
  Suppressed \GreLastOfScore if only no-element syllables follow it. Fixes gregorio-project#1205.
  Cherry pick fc54014
  Bump Copyright year.
  Change package loading order to account for TeXLive 2016
  Cherry pick 54bc8b8
  Load PlainTeX version of xstring
  Cherry pick ca8b226
  Update Version number
  CHANGELOG entries
  Fix issue with custom spaces
  Reach the translation glyph node by traverse_id()
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Sep 24, 2016
* release-4.2: (72 commits)
  Added a test for the suppression of \GreLastOfScore. Tests gregorio-project/gregorio#1205.
  Updated test harness to handle gregorio executable with version number. Tests gregorio-project/gregorio#1197.
  Updated tests to match the oriscus orientation at unison change. Tests gregorio-project/gregorio#1177.
  Small inconsistency
  Added a test to exercise per-line dimension changes. Tests gregorio-project/gregorio#1156.
  Accepted test results after merge.
  accept tests for fix-1144
  accept changes for #1169
  accept tests for 1146
  accept tests for #1146
  accept changes for fix-1138
  changes for fix-1137
  Accepted updated results after merging gregorio-project/gregorio#1154. Tests gregorio-project/gregorio#1153.
  Accepted updated results after merge of release-4.2 into fix-1155.
  accept changes for fix-1152
  add tests for 1155
  accept tests for fix-1155
  Accepted expectations after #1148. Tests gregorio-project/gregorio#1145.
  Added the test from gregorio-project/gregorio#1141.
  Added the test from gregorio-project/gregorio#1139.
  ...
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Sep 25, 2016
* master:
  Update known failures in README
  Added a test for the suppression of \GreLastOfScore. Tests gregorio-project/gregorio#1205.
  Updated test result
  Change luatex-ja test to have its own gabc file and modify to test for proplem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants