Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect auto-custos on clef change at the end of a line #569

Closed
henryso opened this issue Aug 19, 2015 · 2 comments
Closed

Incorrect auto-custos on clef change at the end of a line #569

henryso opened this issue Aug 19, 2015 · 2 comments
Assignees
@henryso
Labels
bug C TeX
Milestone
4.0

Comments

@henryso
Copy link
Contributor

henryso commented Aug 19, 2015

The automatic custos between the two pictured lines was generated with (z0::c3). Because of the clef change, the custos should be showing on the top line, but it is not.

image

The generated GregorioTeX code is correct:

\GreDiscretionary{%
\GreSyllable{}{}{}{1}{\GreSetNextSyllable{}{}{}}{}{0}{}{%
\GreInDivisioFinalis{}%
}%
%
}{%
\GreSyllable{}{}{}{1}{\GreSetNextSyllable{}{}{}}{}{0}{}{%
\GreEndOfElement{1}{1}%
\GreCusto{12}%
\GreInDivisioFinalis{}%
\GreChangeClef{c}{3}{0}{3}%
}%
%
}%

Notably, the \GreCusto{12} does indicate that the custos should be on the top line. It would appear that the "localrightcontent" supplants this setting with one based on the physical position of the next note.
@henryso henryso added this to the 4.0 milestone Aug 19, 2015
@henryso henryso added C and removed TeX labels Aug 20, 2015
@henryso henryso self-assigned this Aug 20, 2015
@henryso henryso added the TeX label Aug 20, 2015
henryso added a commit to henryso/gregorio that referenced this issue Aug 20, 2015
@henryso
Considered automatic custos when setting the next custos.
88649c6 
Recomputed the next custos if the clef change discretionary is printed.
Fixes gregorio-project#569.
@henryso
Copy link
Contributor Author

henryso commented Aug 20, 2015

What's happening is that the computation for the "next note pitch" in Gregorio is not considering the automatic custos created by z0. However, after accounting for that pitch, it needs to be undone if the discretionary does print before the end of a line (i.e, with 'Z', which was luckily covered by the alternate clef test).

@henryso henryso mentioned this issue Aug 20, 2015
Merged
henryso added a commit to henryso/gregorio that referenced this issue Aug 20, 2015
@henryso
Fixed manual custos at the end of lines by using the automatic custos…
246dba1 
… code.

Fixes gregorio-project#569.
@eroux
Copy link
Contributor

eroux commented Aug 21, 2015

fixed by #571

@henryso henryso closed this as completed Aug 21, 2015
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Aug 21, 2015
@rpspringuel
Merge commit 'dfad299d4d6275ec985aada13ee1b262cd6006e7' into texrenam…
d279b1d 
…ingiii

* commit 'dfad299d4d6275ec985aada13ee1b262cd6006e7':
  Fixed manual custos at the end of lines by using the automatic custos code. Fixes gregorio-project#569.
  Considered automatic custos when setting the next custos. Recomputed the next custos if the clef change discretionary is printed. Fixes gregorio-project#569.
  Symlinked indentation profile into the vowel directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryso henryso

Labels
bug C TeX
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@eroux @henryso