-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical episemus on low notes ignored in vertical spacing #60
Comments
Is this still on the docket for 3.0? |
Good point, as it might introduce an incompatible change, maybe it would be good to do it... I can do it (tomorrow), if someone wants to do it before, please do! |
How incompatible a change? Does the user have to modify their gabc or tex files? If it's just a bug-fix, even if it changes the output (thus fixing the bug), then this can even be considered a patch release (i.e., 3.0.1). Also, if I understand the bug description, it's a problem with the C code, right? That the C code chooses the incorrect value for the parameter? Is this a long-standing bug? If it wasn't introduced recently (i.e., 2.4.2, 2.4.3, 3.0.0), then I'd vote to wait for the next release instead of rushing a fix. |
This should be a bugfix change. It will change scores visually, but there is no change in the underlying gabc or in a user's TeX. It is a long-standing bug. I discovered it while making my changes to the spacing code, but didn't fix it at the time. Fixing it requires a change in the C code (to pick the correct value for the parameter) and making some modifications to |
Oh ok, I thought incompatible changes would have to occur in the generated tex files, but if it's not the case, we can delay this feature. |
As far as I can tell, the C code pas passing 4 for the first argument. I think the problem is that |
Did anyone check to see that |
I've confirmed that |
When a score has a low note of
a'
orb'
the presence of the episemus is ignored when determining the spacing between the notes and the text. This leads to the text overlapping with the episemus.The problem appears to be in the first argument choices that Gregorio makes for
\grefirstlinebottomspace
. They should be:0. note on first line or higher
c
)b
) or note below first line with vertical episemus (c'
)a
) or note on 0th line with vertical episemus (b'
)a'
)Cases appear to currently be:
0. note on first line or higher
c
)b
) or note below first line with vertical episemus (c'
)a
)For consistency, case 1 should also be selected for note on first line with vertical episemus (
d'
), but my testing indicates that there is no spacing issue there right now.The text was updated successfully, but these errors were encountered: