Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\grecross and \grealtcross have been swapped #713

Closed
olivierberten opened this issue Dec 13, 2015 · 7 comments
Closed

\grecross and \grealtcross have been swapped #713

olivierberten opened this issue Dec 13, 2015 · 7 comments
Assignees
Milestone

Comments

@olivierberten
Copy link

\grecross used to produce a maltese cross but now you need to type \grealtcross in order to produce the same result...

@henryso
Copy link
Contributor

henryso commented Dec 13, 2015

Anyone know if this was working correctly in 3.0.3 ?

@olivierberten
Copy link
Author

No idea... I was still using 2.4...

@henryso
Copy link
Contributor

henryso commented Dec 13, 2015

If it is a bug in 4.0.0 vs 3.0.3, it becomes a high priority to be a bug we fix for 4.0.1. However, if it's been this way since 3.0.3, then we need to discuss how to deal with it since some people will have used the new behavior, so we can't call at bug so much as a change in behavior.

@rpspringuel
Copy link
Contributor

I think the most likely point for this sort of swap to have been introduced is when we changed the font interface system. Perhaps the names of the crosses in the font got switched in that process?

@henryso
Copy link
Contributor

henryso commented Dec 14, 2015

I don't dispute that. What I'm trying to determine is the course of action here:

  • If it's a bug introduced between 3.0 and 4.0, then it should be fixed in 4.0.1 as a bug
  • If it was introduced between 2.4 and 3.0, no one noticed it, so we have to choose whether to treat this as a bug and fix it (which would break documents created during the 3.0 era that use the \grecross in its 3.0 behavior) or just document it (which breaks documents created prior to 2.4 that use the \grecross in its 2.x behavior).

@rpspringuel
Copy link
Contributor

Right, I was hoping that by identifying what might have caused the error, I could narrow down the search parameters for some one trying to differentiate between the two situations you describe. Seeing as I didn't have the time to actually conduct that search myself, it was the best I could do at the time.

Now that I have the time:
Main.pdf

Main.pdf

It looks like the swap was between 3.0.3 and 4.0.0, making this a bug.

@henryso
Copy link
Contributor

henryso commented Dec 14, 2015

Perfect. Thanks.

@henryso henryso added this to the 4.0 milestone Dec 14, 2015
@henryso henryso self-assigned this Dec 14, 2015
henryso added a commit to henryso/gregorio that referenced this issue Dec 14, 2015
henryso added a commit to henryso/gregorio-test that referenced this issue Dec 14, 2015
henryso added a commit to gregorio-project/gregorio-test that referenced this issue Dec 14, 2015
Updated test/expectation to cover the fix for gregorio-project/gregorio#713.
@henryso henryso closed this as completed Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants