Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing rythmic signs #936

Closed
eroux opened this issue Feb 19, 2016 · 2 comments
Closed

removing rythmic signs #936

eroux opened this issue Feb 19, 2016 · 2 comments
Assignees
@eroux
Labels
enhancement TeX
Milestone
4.1

Comments

@eroux
Copy link
Contributor

eroux commented Feb 19, 2016

I don't know how I can not have thought about that before, but Solesmes just asked for something both very useful and very simple to implement (in fact, so simple that I'm wondering if it could make it in 4.1?): the possibility to remove rythmic signs in TeX. The idea would be to have something like

\grerythmicsigns{x}{y}

where

  • x would be hepisemus, vepisemus, mora or all
  • y would be enable or disable

This looks like a quite safe 20 lines patch... What do you think?
@henryso
Copy link
Contributor

henryso commented Feb 19, 2016

I am fine with this in general, but am only OK with putting it in 4.1 only if it is truly as safe as it seems. Let's not forget that support for 4.1 is going to last for at least a year.

@eroux
Copy link
Contributor Author

eroux commented Feb 19, 2016

Sure, I'll try to come up with a PR tomorrow, we'll see the complexity then.

eroux added a commit that referenced this issue Feb 20, 2016
@eroux
fix #936
09888f5
@eroux eroux mentioned this issue Feb 20, 2016
Closed
@henryso henryso closed this as completed Feb 20, 2016
@henryso henryso added this to the 4.1 milestone Feb 20, 2016
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Feb 20, 2016
@rpspringuel
Merge commit 'f704f0528a75c1219d69a42c4c6840afaf26fe16' into feature/…
2d90c8f 
…maxoffset_nobar

* commit 'f704f0528a75c1219d69a42c4c6840afaf26fe16':
  address comment: episemus -> episema
  fix gregorio-project#936
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Feb 20, 2016
@rpspringuel
Merge commit '611e8ea49399cd990e4be0eb823c29bdafd749f4' into feature/…
403e68f 
…backwardsbar

* commit '611e8ea49399cd990e4be0eb823c29bdafd749f4':
  address comment: episemus -> episema
  Apparently I don't know my right from my left
  Refine offset limiting calculations
  fix gregorio-project#936
  Allow no-bar syllables to use different offset limits than normal bar syllables.
  Start fixing gregorio-project#921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eroux eroux

Labels
enhancement TeX
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
2 participants
@eroux @henryso