Addresses #1036 #1058
Merged
Addresses #1036 #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`interwordspacetext` distances are changed to be dependent on the font Instructions are added to GregorioRef for how the above is accomplished so that the user can do the same.
This was referenced Apr 1, 2016
| @@ -20,6 +20,7 @@ As of v3.0.0 this project adheres to [Semantic Versioning](http://semver.org/). | |||
| - A podatus followed by a virga `(eghv)` will now be kept together (no line break between the shapes), If you would like to allow a line break there, use `(eg/hv)` instead (see UPGRADE.md and [#1045](https://github.com/gregorio-project/gregorio/issues/1045)). | |||
| - Penalties must now be changed using the `\grechangecount` command. See GregorioRef and [UPGRADE.md](UPGRADE.md) for details (for the change request, see [#1021](https://github.com/gregorio-project/gregorio/issues/1021)). | |||
| - `\greemergencystretch` must now be set by changing `emergencystretch` using `\grechangedim` instead of redefining the macro. | |||
| - `interwordspacetext` and it's related distances are now defined as fixed distances based on the `\fontdimen` values. This means that they will scale according to the font, not the staff size. The documenation has been updated to explain how this is done and provide the default definitions. See [#1036](https://github.com/gregorio-project/gregorio/issues/1036). | |||
There was a problem hiding this comment.
I think 99% will be puzzled by the \fontdimen thing, this should probably be explained a little more, like
"based on the \fontdimen values, so that a space between two words in a score is exactly the same as a space between two words in text if notes do not interfere"
something like that...
The extra `\relax` at the end isn't needed and will actually cause problems if `interwordspacetext@euouae` is used in a `\glueexpr` or `\dimexpr`.
|
Hopefully things are clearer now. |
This change increases their size to `1ex` and removes the stuff about using `\fontdimen` (which will be put in the Tips'n'Tricks section of the website).
…fontdimen * commit '53a92da355ea65f880d423c0d45ef1356b2e738f': Prevented an element cut before an isolated stropha. Fixes gregorio-project#1056.
…fontdimen * commit '294a3f643dab09fc3ba8242a1cc47f8912113dde': Implemented alterations for custodes. Fixes gregorio-project#1049.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interwordspacetextdistances are changed to be dependent on the fontInstructions are added to GregorioRef for how the above is accomplished so that the user can do the same.
Lots of tests break, but all in the expected manner. However, I think that these new defaults might be a tad too small. If others would please review the test changes and tell me if they agree or not, I'd appreciate it.