Class methods on Bump was not private as intended #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -421,6 +421,15 @@ module Foo | |||
| end | |||
| end | |||
|
|
|||
| context 'verify private class mothods' do | |||
There was a problem hiding this comment.
private methods don't really need tests ...
There was a problem hiding this comment.
Used the test to verify that private notation had an effect or not.
Before this change the class only had 2 private class methods - inherited from Object
After change there was 19 private methods
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended private methods on Bump::Bump was public available.
This pull request makes them private and all existing test passed after the fix.
Given that the methods might have been used by somebody this change could surprise users.