Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi select to see multiple subreddits at once #461

Merged
merged 10 commits into from Apr 27, 2023

Conversation

rendely
Copy link
Contributor

@rendely rendely commented Apr 8, 2023

Description

These changes add a multi select search, letting users view multiple visual subreddits at once.

Screenshot

https://imgur.com/a/OwfNYBl

@vercel
Copy link

vercel bot commented Apr 8, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @gregrickaby on Vercel.

@gregrickaby first needs to authorize it.

@rendely
Copy link
Contributor Author

rendely commented Apr 8, 2023

Hey there, feel free to reject this change or request any cleanup. I'm learning to code and was using this is a practice opportunity. Appreciate any tips on improvement!

@vercel
Copy link

vercel bot commented Apr 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
viewer-for-reddit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 0:05am

Copy link
Owner

@gregrickaby gregrickaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rendely I really, really like this idea! Would you mind running your PR through prettier first?

Just run npm run format and commit those changes.

Thank you.

@rendely
Copy link
Contributor Author

rendely commented Apr 13, 2023

Absolutely, let me know if that worked!

@rendely
Copy link
Contributor Author

rendely commented Apr 25, 2023

Just checking back in if anything else needed from my side

Copy link
Owner

@gregrickaby gregrickaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rendely Sorry for the delay. Started a new job and have been totally immersed in it.

As I said, I love this approach. LGTM!

@gregrickaby gregrickaby merged commit 4f630d6 into gregrickaby:main Apr 27, 2023
4 checks passed
@rendely
Copy link
Contributor Author

rendely commented Apr 27, 2023

Congrats on the new job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants