New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yandex.ru search engine is still being added #16
Comments
Thanks for the report! We'll look into it. |
Yandex's search field already has a
|
I have tried it too. [edit] by the way, here is a useful code to display the list of all forms and form elements of a page.
|
It is definitively not correct. |
OK- I will wait until I hear more before trying it myself :) . Welcome back! \o/ |
This version should work. Here is the fix: (line 39) This means that we only take named input/text into account. Edit: I'll check if name="" in html tags is caught by the CSS selector. It shouldn't. |
I'll have to refine it to consider name="" as no name at all. |
Something is wrong with the cleanup. Edit; |
Ah! Sorry about that! Thanks for enlightening me. I will amend that
commit next time I am at my console.
I like your idea of passing an object - since all objects are truthy
(except null), the object==Boolean test may not have been ideal anyway.
|
I have a fully functional version here. |
One last modification that we can do is increasing the timer delay. Push it up to 2 or 4 seconds, maybe. |
Hmm... That's a tough one. Would you open a separate issue, please? We might need to make that one a user option, or request tabs permission and count tabs. |
No need to bother too much, 1.5 sec was chosen arbitrarily. We can select another value. It won't break anything at all. |
Updated CSS selector, and using === with this.now in spoilFormGet
Should be fixed in #17 - closing. If you experience further problems, please feel free to comment back! Note that #17 hasn't been deployed yet, so you won't see the updates until @gregsadetsky rolls out v0.0.5. |
Hello,
I'm using Chromium in Ubuntu, current version is 66.0.3359.181. Extension version 0.0.4 allows yandex.ru search engine to be added automatically after submitting making any search.
The text was updated successfully, but these errors were encountered: