New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier sub-schema navigation #15
Comments
I agree with the motivation for this, but I'm struggling to find an elegant solution. For reference:
|
@shadow-cs I'd like to discuss some things about your gist that caught my eye, but such a conversation doesn't suit GitHub well. Do you mind joining my Slack workspace and DM-ing me? |
Offline, @shadow-cs and I discussed and we agree that the best approach would be to add three new interfaces to describe the different types of schema-carrying keywords.
Keywords will implement these keywords as appropriate. This also provides a mechanism for custom keywords to be included in the kind of navigation that's desired. |
Do you have any issue with these interfaces being implemented explicitly? This means that you'd have to cast to the interface to see the properties. It means that I don't have to rename properties, which would be a breaking change. |
Works like a charm, no problems with explicit casting. |
It would be helpful if we can traverse sub-schemas more easily. Currently specific types which hold sub-schemas have to be traversed manually since they share o common ancestor/interface.
A
switch
over all keywords (which have sub-schemas) is currently necessary, see here.Original discussion: #8.
The text was updated successfully, but these errors were encountered: