Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make operators in the specification private protected to allow inheritance. #369

Merged
merged 3 commits into from Jan 23, 2023
Merged

Make operators in the specification private protected to allow inheritance. #369

merged 3 commits into from Jan 23, 2023

Conversation

dcook-net
Copy link

@dcook-net dcook-net commented Jan 21, 2023 •
edited by gregsdennis

Resolves #368

@gregsdennis gregsdennis changed the title Make operators in the specification private protected to allow inheri… Make operators in the specification private protected to allow inheritance. Jan 22, 2023
@gregsdennis gregsdennis changed the base branch from master to logic/rule-accessibility January 22, 2023 21:27
@gregsdennis
Copy link
Owner

I really need to fix that labeler build. It's failing because of permissions across forks.

This was referenced Jan 22, 2023
Merged
Closed
@gregsdennis
Copy link
Owner

@dcook-net can you try rebasing on my logic/rule-accessibility branch please? I don't expect there to be any conflicts.

@dcook-net
Copy link
Author

@gregsdennis 👍🏻 will do this today.

@github-actions github-actions bot added build pipeline documentation Improvements or additions to documentation pkg:logic try-me-site labels Jan 23, 2023
@gregsdennis
Copy link
Owner

Thanks for this. I'll merge it into the branch and tweak a few things. When I merge that into master it'll publish.

@gregsdennis gregsdennis merged commit ddb2a68 into gregsdennis:logic/rule-accessibility Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsdennis gregsdennis gregsdennis left review comments

Assignees
No one assigned
Labels
build pipeline documentation Improvements or additions to documentation pkg:logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could json logic operators be protected interal?
2 participants
@dcook-net @gregsdennis