Stackoverflow when deserializing more than one time with ValidatingJsonConverter

[EmmyDream]

Nuget Package

JsonSchema.Net

Package Version

5.3.0

Operating System

Windows

.Net Target (if relevant, please specify the version in the description)

.Net (5 or after)

A clear and concise description of the bug.

Usage of ValidatingJsonConverter throws stackoverflow after second usage. From my understanding _optionsFactory is not working correctly (ValidatingJsonConverter is not removed from options), when there is a usage of cache - converter has been already defined in cache.

What did you expect?

Not having stackoverflow.

Please add test code or steps to reproduce the behavior.

I have followed instruction here https://docs.json-everything.net/schema/serialization/, how to use ValidatingJsonConverter with attribute on deserializing type.

Is there any other information you'd like to share regarding this bug?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[gregsdennis]

Thanks for reporting. I'll have a look.

[gregsdennis]

I've added this test which runs deserialization 10 times repeatedly. It passes.

[Test]
public void WithSchema_MultipleDeserializations()
{
    try
    {
        var jsonText = @"{
  ""Bar"": ""bartholomew"",
  ""Value"": 42
}";

        for (int i = 0; i < 10; i++)
        {
            var model = JsonSerializer.Deserialize<FooWithSchema>(jsonText, _options);

            Console.WriteLine(JsonSerializer.Serialize(model, _options));
        }
    }
    catch (Exception e)
    {
        HandleException(e);
        throw;
    }
}

Can you provide a replicating test, please?

[EmmyDream]

Hello, thank you for your test. Please update it as follow:

    [Test]
    public void WithSchema_MultipleDeserializations()
    {
        try
        {
            var jsonText = @"{
  ""Bar"": ""bartholomew"",
  ""Value"": 42
}";
            
            for (int i = 0; i < 10; i++)
            {
                var options = new JsonSerializerOptions
                {
                    WriteIndented = true,
                    Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
                    Converters = { new ValidatingJsonConverter { OutputFormat = OutputFormat.List } }
                };
                
                var model = JsonSerializer.Deserialize<FooWithSchema>(jsonText, options);

                Console.WriteLine(JsonSerializer.Serialize(model, options));
            }
        }
        catch (Exception e)
        {
            HandleException(e);
            throw;
        }
    }

[gregsdennis]

Interesting. You're generating new options objects for each iteration? Why not create a static one and re-use that?

(I'll fix this, obviously, but it's still worth asking the question.)

[EmmyDream]

Interesting. You're generating new options objects for each iteration? Why not create a static one and re-use that?

(I'll fix this, obviously, but it's still worth asking the question.)

For example, lets consider some scope service like this:

private class FooService
 {
     private readonly JsonSerializerOptions _fooOptions = new JsonSerializerOptions
     {
         WriteIndented = true,
         Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
         Converters = { new ValidatingJsonConverter { OutputFormat = OutputFormat.List } }
     };
     
     public FooWithSchema DeserializeFoo(string jsonText)
     {
         return JsonSerializer.Deserialize<FooWithSchema>(jsonText, _fooOptions);

     }
 }

And test method:

    [Test]
    public void WithSchema_MultipleDeserializations()
    {
        try
        {
            var jsonText = @"{
  ""Bar"": ""bartholomew"",
  ""Value"": 42
}";
            
            for (int i = 0; i < 10; i++)
            {
                var model = new FooService().DeserializeFoo(jsonText);
                Console.WriteLine(JsonSerializer.Serialize(model, _options));
            }
        }
        catch (Exception e)
        {
            HandleException(e);
            throw;
        }
    }

In my case I have common implementation of deserialization service, which allows to provide different JsonSerializerOptions, so that is why these options are coming from outside implementation and can be created each time when I call common service.

Anyway thank you for a quick fix! I will test it