Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log message if jupyter not found instead of json-readtable-error #156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Log message if jupyter not found instead of json-readtable-error #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81b980f
Don't error if jupyter not found while auto-configuring kernels
jjlee Feb 3, 2018
0cbe70a
Show output in the auto-configure failure message as well as command
jjlee Feb 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions ob-ipython.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,17 +501,24 @@ a new kernel will be started."
"Return a list of available jupyter kernels and their corresponding languages.
The elements of the list have the form (\"kernel\" \"language\")."
(and ob-ipython-command
(let ((kernelspecs (cdar (json-read-from-string
(shell-command-to-string
(s-concat ob-ipython-command " kernelspec list --json"))))))
(-map (lambda (spec)
(cons (symbol-name (car spec))
(->> (cdr spec)
(assoc 'spec)
cdr
(assoc 'language)
cdr)))
kernelspecs))))
(let*
((kernelspecs-cmd (s-concat ob-ipython-command " kernelspec list --json"))
(kernelspecs-text (shell-command-to-string kernelspecs-cmd))
(kernelspecs
(condition-case-unless-debug nil
(cdar (json-read-from-string kernelspecs-text))
(json-readtable-error
(message "Failed to list jupyter kernels with: %s, got:\n%s" kernelspecs-cmd kernelspecs-text)
nil))))
(when kernelspecs
(-map (lambda (spec)
(cons (symbol-name (car spec))
(->> (cdr spec)
(assoc 'spec)
cdr
(assoc 'language)
cdr)))
kernelspecs)))))

(defun ob-ipython--configure-kernel (kernel-lang)
"Configure org mode to use specified kernel."
Expand Down