fix broken interrupt-kernel on unix #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #115 (broken
ob-ipython-interrupt-kernel
) on linux and (probably) mac.To interrupt the kernel, SIGINT needs to be sent to the appropriate process. This process is not the "jupyter console" process itself, but rather a child process of it ("python -m ipykernel_launcher ..."). The old code was sending SIGINT to the wrong process.
As the process to signal is not a direct subprocess of emacs, I had to resort to unix tools to interrupt it, so this won't work on windows. An alternative approach might be to start the kernel with
ipython kernel
instead ofjupyter console
, then it would be a direct subprocess of emacs and we could interrupt it with(interrupt-process)
as before.Note it currently appears impossible to interrupt remote kernel, as noted in jupyter/jupyter_console#150